Expand global search (cache-first accounts, category drill-out) - #13
Merged
Conversation
Cache-first owned accounts, category drill-out to transactions, partial-success UX, and SearchViewModel test plan. Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Use Room-backed owned accounts in search, keep account/category hits when transaction search fails, and navigate category results into filtered transactions. Refs pledger-io/.github#36. Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
gjong
marked this pull request as ready for review
July 27, 2026 12:52
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements pledger-io/.github#36: expand global search MVP for reliability and drill-out.
Design:
docs/design/expanded-global-search.mdChanges
observeOwnedAccounts()(no forced refresh per query)SearchViewModelunit tests; README + ADR-017 noteTest plan
Related: roadmap #34 “Expanded global search”.